Merging Pull Requests¶
To build new images and publish them to the Docker Hub registry, do the following:
Make sure GitHub Actions status checks pass for the PR.
Merge the PR.
Monitor the merge commit GitHub Actions status. Note: we think, GitHub Actions are quite reliable, so please, investigate, if some error occurs. The process of building docker images in PRs is exactly the same after merging to master, except there is an additional
Try to avoid merging another PR to master until all pending builds complete. This way you will know which commit might have broken the build and also have correct tags for moving tags (like
Updating the Ubuntu Base Image¶
When there’s a security fix in the Ubuntu base image or after some time passes, it’s a good idea to update the pinned SHA in the jupyter/base-notebook Dockerfile. Submit it as a regular PR and go through the build process. Expect the build to take a while to complete: every image layer will rebuild.
Adding a New Core Image to Docker Hub¶
When there’s a new stack definition, do the following before merging the PR with the new stack:
Ensure the PR updates the Makefile which is used to build the stacks in order on GitHub Actions.
Ensure necessary tags / manifests are added for the new image in the tagging folder.
Create a new repository in the
jupyterorg on Docker Hub named after the stack folder in the git repo.
stacksteam permission to write to the repo.
Adding a New Maintainer Account¶
Add the maintainer’s Docker Hub username.
Add the maintainer’s GitHub username.
Pushing a Build Manually¶
If automated build in Github Actions has got you down, do the following to push a build manually:
Clone this repository.
Check out the git SHA you want to build and publish.
docker loginwith your Docker Hub credentials.
Enabling a New Doc Language Translation¶
First enable translation on Transifex:
Click Edit Languages in the top right.
Select the language from the dropdown.
Then setup a subproject on ReadTheDocs for the language:
Enter jupyter-docker-stacks-language_abbreviation for the project name.
Enter https://github.com/jupyter/docker-stacks for the URL.
Check Edit advanced project options.
Select the Language from the dropdown on the next screen.
Finally link the new language subproject to the top level doc project:
Select the subproject you created from the Project dropdown.